Use fastcrc, instead of custom implementation, make modules proper python, and use prebuild cyclonedds#107
Open
carlosdp wants to merge 9 commits intounitreerobotics:masterfrom
Open
Conversation
|
This is awesome, what changes need to be made to make your changes compatible with uv? I really want to be able to integrate the python Unitree sdk with uv |
Author
No changes! We use |
|
This implementation fixes all of the problems I have with using the Unitree Python SDK, great work! |
Author
|
Thank you @Kaweees ! |
10 tasks
MiaoDX
pushed a commit
to MiaoDX-fork-and-pruning/unitree_sdk2_python_uv
that referenced
this pull request
Apr 4, 2026
Based on @carlosdp's PR unitreerobotics#107. - Add __init__.py files to all subpackages for proper Python module resolution - Migrate from setup.py to pyproject.toml with full project metadata - Add cyclonedds pre-built wheel dependencies for macOS (x86_64/arm64) and Linux (x86_64/aarch64) - Add fastcrc, numpy, opencv-python as project dependencies - Add a note to README explaining the fork origin and changes - Update .gitignore for Python packaging artifacts https://claude.ai/code/session_01Er2d4LqFWhD6J43Jkn8vfW
MiaoDX
pushed a commit
to MiaoDX-fork-and-pruning/unitree_sdk2_python_uv
that referenced
this pull request
Apr 4, 2026
Based on @carlosdp's PR unitreerobotics#107. - Add __init__.py files to all subpackages for proper Python module resolution - Migrate from setup.py to pyproject.toml with full project metadata - Add cyclonedds pre-built wheel dependencies for macOS (x86_64/arm64) and Linux (x86_64/aarch64) - Add fastcrc, numpy, opencv-python as project dependencies - Add a note to README explaining the fork origin and changes - Update .gitignore for Python packaging artifacts https://claude.ai/code/session_01Er2d4LqFWhD6J43Jkn8vfW
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes that make the library easier to install and more compatible with different developer machines (without performance trade-off).
fastcrcpython library for native, fast CRC implementation support on more platforms (including Mac/darwin), so falling back to pure python implementation is no longer necessary. Also makes the CRC implementation more transparent/auditable, since the source code for the crc library used currently is not available.__init__.pyin their roots, so they are compatible with all python dependency tooling.cyclonedds @ 0.10.5I have made and published in https://github.com/carlosdp/cyclonedds-python , so developers never have to build cyclone on their own! That part of the README can be removed after this change.The net effect of this PR is that this SDK can be installed with just
pip install git+https://github.com/unitreerobotics/unitree_sdk2_python🎉🥳